-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some dataposter metrics #2523
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the following metrics to the DataPoster: arb/dataposter/nonce/unconfirmed: current unconfirmed nonce arb/dataposter/nonce/finalized: nonce as of finalized block arb/dataposter/nonce/softconfirmed: soft confirmed nonce ie nonce as of latest block number - nonce-rbf-soft-confs arb/dataposter/queue/length: number of unconfirmed batches in the queue arb/dataposter/queue/weight: weight of unconfirmed batches in the queue All are udpated every 10 seconds except softconfirmed, which is updated is updated whenever there is a new batch posted or a tx is replaced.
cla-bot
bot
added
the
s
Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
label
Jul 25, 2024
gligneul
previously approved these changes
Jul 25, 2024
eljobe
reviewed
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
amsanghi
previously approved these changes
Jul 26, 2024
PlasmaPower
requested changes
Jul 30, 2024
PlasmaPower
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design-approved
s
Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the following metrics to the DataPoster:
All are udpated every 10 seconds except softconfirmed, which is updated is updated whenever there is a new batch posted or a tx is replaced.
Fixes NIT-2657