Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some dataposter metrics #2523

Merged
merged 8 commits into from
Aug 5, 2024
Merged

Add some dataposter metrics #2523

merged 8 commits into from
Aug 5, 2024

Conversation

Tristan-Wilson
Copy link
Member

@Tristan-Wilson Tristan-Wilson commented Jul 25, 2024

This commit adds the following metrics to the DataPoster:

  • arb/dataposter/nonce/unconfirmed: current unconfirmed nonce
  • arb/dataposter/nonce/finalized: nonce as of finalized block
  • arb/dataposter/nonce/softconfirmed: soft confirmed nonce ie nonce as of latest block number - nonce-rbf-soft-confs
  • arb/dataposter/queue/length: number of unconfirmed batches in the queue
  • arb/dataposter/queue/weight: weight of unconfirmed batches in the queue

All are udpated every 10 seconds except softconfirmed, which is updated is updated whenever there is a new batch posted or a tx is replaced.

Fixes NIT-2657

This commit adds the following metrics to the DataPoster:

arb/dataposter/nonce/unconfirmed: current unconfirmed nonce
arb/dataposter/nonce/finalized: nonce as of finalized block
arb/dataposter/nonce/softconfirmed: soft confirmed nonce
      ie nonce as of latest block number - nonce-rbf-soft-confs
arb/dataposter/queue/length: number of unconfirmed batches in the queue
arb/dataposter/queue/weight: weight of unconfirmed batches in the queue

All are udpated every 10 seconds except softconfirmed, which is updated
is updated whenever there is a new batch posted or a tx is replaced.
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jul 25, 2024
gligneul
gligneul previously approved these changes Jul 25, 2024
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amsanghi
amsanghi previously approved these changes Jul 26, 2024
arbnode/dataposter/data_poster.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tristan-Wilson Tristan-Wilson merged commit 9cad8ad into master Aug 5, 2024
13 checks passed
@Tristan-Wilson Tristan-Wilson deleted the dataposter-metrics branch August 5, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants