Fix live reloading of staker config #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
joshuacolvin0
requested changes
Aug 19, 2024
| @@ -660,7 +660,7 @@ func createNodeImpl( | |||
| confirmedNotifiers = append(confirmedNotifiers, messagePruner) | |||
| } | |||
|
|
|||
| stakerObj, err = staker.NewStaker(l1Reader, wallet, bind.CallOpts{}, config.Staker, blockValidator, statelessBlockValidator, nil, confirmedNotifiers, deployInfo.ValidatorUtils, fatalErrChan) | |||
| stakerObj, err = staker.NewStaker(l1Reader, wallet, bind.CallOpts{}, func() *staker.L1ValidatorConfig { return &configFetcher.Get().Staker }, blockValidator, statelessBlockValidator, nil, confirmedNotifiers, deployInfo.ValidatorUtils, fatalErrChan) | |||
There was a problem hiding this comment.
This means that the options in Staker will only be loaded during startup, the hot reloadable flag will be ignored.
There was a problem hiding this comment.
Since the staker now takes a function of type L1ValidatorConfigFetcher which is a function that would call configFetcher every time we invoke it this effectively implements live reloading.
(this impl is similar to how its done for other hot-reloadable configs such as batchposterconfig
Line 697 in 7ccb6ad
I've tested this locally that hot-reloadable options are updated periodically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In staker's L1ValidatorConfig, most of the fields with hot-reload tag (except
log-query-batch-size) are not used inside staker itself but used and handled correctly in different other places. PreviouslyStakerstruct didn't implement live-reloading of its config even though it was marked ashot-reload, this PR fixes it.Note: Since most fields are not required to be hot-reloaded, this PR also tries to minimize invoking
L1ValidatorConfigFetcherfield of staker to lower the number of RLocksResolves NIT-2660