Fix spurious refund error log to just be debug #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
tsahee
requested changes
Aug 29, 2024
| @@ -532,20 +532,30 @@ func (p *TxProcessor) EndTxHook(gasLeft uint64, success bool) { | |||
| refund := func(refundFrom common.Address, amount *big.Int) { | |||
| const errLog = "fee address doesn't have enough funds to give user refund" | |||
|
|
|||
| logMissingRefund := func(err error) { | |||
There was a problem hiding this comment.
lets amend util.TransferBalance to give a specific error for low balance and test that this was indeed the error received.
There was a problem hiding this comment.
I've added a check for the error type. There's already a dedicated error type for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error log was put in place when the fee accounts were EOAs, but now that they're contracts it's expected that this might be hit.