PeriodToAllowPostingBatchWithOnlyBatchPostingReport config #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
diegoximenes
force-pushed
the
allow_only_posting_batch_posting_report
branch
from
b3b8501
to
df0da33
Compare
diegoximenes
requested review from
ganeshvanahalli,
Tristan-Wilson and
amsanghi
amsanghi
previously approved these changes
Sep 23, 2024
ganeshvanahalli
previously approved these changes
Oct 4, 2024
tsahee
requested changes
Oct 8, 2024
diegoximenes
dismissed stale reviews from ganeshvanahalli and amsanghi
via
52f6a6c
diegoximenes
force-pushed
the
allow_only_posting_batch_posting_report
branch
from
df0da33
to
52f6a6c
Compare
diegoximenes
changed the title
tsahee
requested changes
Oct 11, 2024
arbnode/batch_poster.go
Outdated
| Dangerous BatchPosterDangerousConfig `koanf:"dangerous"` | ||
| ReorgResistanceMargin time.Duration `koanf:"reorg-resistance-margin" reload:"hot"` | ||
| CheckBatchCorrectness bool `koanf:"check-batch-correctness"` | ||
| PeriodToAllowPostingBatchWithOnlyBatchPostingReport time.Duration `koanf:"period-to-allow-posting-batch-with-only-batch-posting-report"` |
There was a problem hiding this comment.
Need to find a simpler name.
A batch posting report is automatically added (by the inbox smart-contract) every time a batch is posted. Orbit deployers don't usually understand too well what is a "batch-posting-report". They will experience it as maximum delay between batches even if they are empty.
I want something close to "max-deay" that shows the difference.
Maybe "max-empty-batch-delay"?
There was a problem hiding this comment.
Renamed to max-empty-batch-delay
|
Seems to be failing CI now due to merge conflicts of firstMsgTime no longer existing. I think substituting |
…batch with only batch posting report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves NIT-2720.
PeriodToAllowPostingBatchWithOnlyBatchPostingReport config.
SequencerInbox contract adds a batch posting report to the delayed inbox after a batch is posted to the non delayed inbox.
The sequencer will read the batch posting report from the delayed inbox, and the PeriodToAllowPostingBatchWithOnlyBatchPostingReport config allows the batch poster to post batches that only contain batch posting report messages.
This is going to be useful to avoid allowing validation being permissionless if there have been no assertions created within a 2 week period, behavior which is controlled by Nitro's contracts.