[config change] Improve BlocksReExecutor implementation #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
s
magicxyyz
requested changes
Oct 1, 2024
eljobe
previously approved these changes
Oct 3, 2024
tsahee
requested changes
Oct 7, 2024
tsahee
requested changes
Oct 28, 2024
tsahee
previously approved these changes
Nov 4, 2024
ganeshvanahalli
dismissed stale reviews from magicxyyz and tsahee
via
860f54a
tsahee
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the implementation of blocks re-execution mainly to use a separate stateDB during each block's re-execution and to verify that the resulting state successfully commits.
Config option
--blocks-reexecutor.blocks-per-threadis renamed to--blocks-reexecutor.min-blocks-per-thread.A new config option
--blocks-reexecutor.trie-clean-limit(memory allowance in MB to use for caching trie nodes in memory) is added.Pulls geth PR- OffchainLabs/go-ethereum#364
Resolves NIT-2810