Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Config Change] document the fact OCL does not support google cloud storage #2727

Merged
merged 2 commits into from
Oct 9, 2024
Merged

[Config Change] document the fact OCL does not support google cloud storage #2727

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d643fd
document the fact OCL does not support google cloud storage
tsahee Oct 7, 2024
9789718
Merge branch 'master' into google_storage_experimental
tsahee Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions das/google_cloud_storage_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,24 @@
package das

import (
googlestorage "cloud.google.com/go/storage"
"context"
"fmt"
"io"
"math"
"sort"
"time"

googlestorage "cloud.google.com/go/storage"
"github.com/google/go-cmp/cmp"
flag "github.com/spf13/pflag"
"google.golang.org/api/option"

"github.com/ethereum/go-ethereum/common"
"github.com/ethereum/go-ethereum/log"
"github.com/google/go-cmp/cmp"

"github.com/offchainlabs/nitro/arbstate/daprovider"
"github.com/offchainlabs/nitro/das/dastree"
"github.com/offchainlabs/nitro/util/pretty"
flag "github.com/spf13/pflag"
"google.golang.org/api/option"
"io"
"math"
"sort"
"time"
)

type GoogleCloudStorageOperator interface {
Expand Down Expand Up @@ -69,7 +72,7 @@ type GoogleCloudStorageServiceConfig struct {
var DefaultGoogleCloudStorageServiceConfig = GoogleCloudStorageServiceConfig{}

func GoogleCloudConfigAddOptions(prefix string, f *flag.FlagSet) {
f.Bool(prefix+".enable", DefaultGoogleCloudStorageServiceConfig.Enable, "enable storage/retrieval of sequencer batch data from an Google Cloud Storage bucket")
f.Bool(prefix+".enable", DefaultGoogleCloudStorageServiceConfig.Enable, "EXPERIMENTAL/unsupported - enable storage/retrieval of sequencer batch data from an Google Cloud Storage bucket")
f.String(prefix+".access-token", DefaultGoogleCloudStorageServiceConfig.AccessToken, "Google Cloud Storage access token")
f.String(prefix+".bucket", DefaultGoogleCloudStorageServiceConfig.Bucket, "Google Cloud Storage bucket")
f.String(prefix+".object-prefix", DefaultGoogleCloudStorageServiceConfig.ObjectPrefix, "prefix to add to Google Cloud Storage objects")
Expand Down
Loading