Set better arbos defaults for new chains #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #978 +/- ##
==========================================
- Coverage 51.86% 47.78% -4.09%
==========================================
Files 229 217 -12
Lines 28889 24756 -4133
Branches 511 511
==========================================
- Hits 14983 11829 -3154
+ Misses 12326 11347 -979
Partials 1580 1580 |
edfelten
requested changes
Aug 17, 2022
|
Btw I've adjusted this initialization to happen in v6, which is good for testing and lets us adopt this immediately on new chains |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
firstTimeflag to the upgrade loop so that new chains can have different defaultsAlso exposes additional l1 pricing params in
arbdebug