Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log exception when one of the tests fails #75

Closed
waldekmastykarz opened this issue Oct 18, 2015 · 2 comments
Closed

Log exception when one of the tests fails #75

waldekmastykarz opened this issue Oct 18, 2015 · 2 comments

Comments

@waldekmastykarz
Copy link
Contributor

When one of the tests in $ gulp test breaks at the end you get the following error:

/Users/usr/github/generator-office/gulpfile.js:129
  $.log(err.toString());
    ^
TypeError: undefined is not a function
    at Stream.handleError (/Users/usr/github/generator-office/gulpfile.js:129:5)
    at Stream.emit (events.js:129:20)

Shouldn't https://github.com/OfficeDev/generator-office/blob/master/gulpfile.js#L129 be referring to the function defined in https://github.com/OfficeDev/generator-office/blob/master/gulpfile.js#L113 (so calling log rather than $.log)?

andrewconnell added a commit to andrewconnell/generator-office that referenced this issue Oct 28, 2015
@andrewconnell
Copy link
Contributor

This is an error, but it shouldn't call the local function log() because that writes out a successful message in blue all the time. It just needs to call the $.util.log() function instead.

@andrewconnell
Copy link
Contributor

Fixed in #85

andrewconnell added a commit that referenced this issue Oct 28, 2015
Fixes #75 where gulp errored out on failed test `$ gulp test`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants