refactor: cleanup code #13133
Merged
refactor: cleanup code #13133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import { manifestUtils } from "../../driver/teamsApp/utils/ManifestUtils"; | ||
| import { ActionContext } from "../../middleware/actionExecutionMW"; | ||
| import { declarativeCopilotInstructionFileName } from "../constant"; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 5 days ago
The best way to fix the problem is to remove the unused import statement. This will clean up the code and eliminate any confusion about the dependencies of the module. The change should be made in the file packages/fx-core/src/component/generator/apiSpec/generator.ts by removing the line that imports declarativeCopilotInstructionFileName.
Suggested changeset
1
packages/fx-core/src/component/generator/apiSpec/generator.ts
| @@ -51,3 +51,3 @@ | ||
| import { ActionContext } from "../../middleware/actionExecutionMW"; | ||
| import { declarativeCopilotInstructionFileName } from "../constant"; | ||
|
|
||
| import { Generator } from "../generator"; |
Copilot is powered by AI and may make mistakes. Always verify output.
yuqizhou77
requested review from
nliu-ms,
Alive-Fish,
jayzhang,
anchenyi and
huimiu
as code owners
yuqizhou77
commented
Feb 6, 2025
| @@ -80,20 +77,10 @@ export class CopilotExtensionGenerator extends DefaultTemplateGenerator { | |||
| inputs.targetFramework, | |||
| inputs.placeProjectFileInSolutionDir === "true" | |||
| ), | |||
| DeclarativeCopilot: isDeclarativeCopilot ? "true" : "", | |||
| DeclarativeCopilot: "true", | |||
There was a problem hiding this comment.
Ideally this line can be removed, but depends on #13134
tecton
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ut
