Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for transparency when deriving FromColor and IntoColor #86

Closed
Ogeon opened this issue Apr 3, 2018 · 0 comments
Closed

Add support for transparency when deriving FromColor and IntoColor #86

Ogeon opened this issue Apr 3, 2018 · 0 comments
Milestone

Comments

@Ogeon
Copy link
Owner

Ogeon commented Apr 3, 2018

A custom color can't have transparency at the moment. A part of the problem is that it's not possible to implement From for Alpha<MyColor, T>. A possible solution is to add a #[palette_alpha] attribute that marks the alpha component in the custom color struct and extend the derive code to use this when implementing From and Into, to preserve the transparency.

@Ogeon Ogeon added this to the 0.4.0 milestone Apr 3, 2018
bors bot added a commit that referenced this issue Apr 28, 2018
92: Add transparency support when deriving FromColor and IntoColor r=Ogeon a=Ogeon

Closes #86 

Co-authored-by: Erik Hedvall <erikwhedvall@gmail.com>
@bors bors bot closed this as completed in #92 Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant