You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
140: Add a basic test crate for no_std r=Ogeon a=Ogeon
It's very bare bones, but will hopefully get the job done.
Closes#139
Co-authored-by: Erik Hedvall <erikwhedvall@gmail.com>
Whoops I missed this PR. You definitely need to build against a target that doesn't have std to properly check for it as no_std crates can depend on std crates (for whatever reason), so you don't know if all your dependencies are properly no_std unless you compile against a target that doesn't even have it.
Ouch, alright, I though it worked because it failed to compile (duplicate symbols) when I enabled std. Maybe that's not reliable enough. Do you have an example of how to do it in a better way?
I guess what you have is fine, but I'd additionally also compile it for --target thumbv6m-none-eabi (and then probably just not execute it, unless you want to go through the effort with qemu)
I'm fine with not executing it for now. That's already how it's done here. I will try adding a test for thumbv6m-none-eabi too. Thanks for pointing it out!
141: Also test no_std with a target without std support r=Ogeon a=Ogeon
As suggested in #140 (comment).
Co-authored-by: Erik Hedvall <erikwhedvall@gmail.com>
internalAn internal change that will not be shown in release notes
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ogeon
added
the
internal
It's very bare bones, but will hopefully get the job done.
Closes #139