Change Mix, Shade and Saturate to use an associated type #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The type name |
|
@homu r+ |
|
📌 Commit e78dcdc has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Jan 24, 2016
Change Mix, Shade and Saturate to use an associated type The `Mix`, `Shade` and `Saturate` traits are rewritten to have an associated `Scalar` type instead of a type parameter, as mentioned in [#17](#17 (comment)). This removes the need for extra type parameters in some cases, like in `Gradient`. This is a breaking change, since it removes a number of type parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Mix,ShadeandSaturatetraits are rewritten to have an associatedScalartype instead of a type parameter, as mentioned in #17. This removes the need for extra type parameters in some cases, like inGradient.This is a breaking change, since it removes a number of type parameters.