Separate sRGB and gamma encoded RGB from the Rgb type #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were some talk somewhere about supporting AdobeRGB, but that can be added later. I'll call this one done. @homu r+ |
|
📌 Commit babb5ee has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Jan 24, 2016
Separate sRGB and gamma encoded RGB from the Rgb type This closes #7 by adding separate types for sRGB and gamma encoded RGB. `Rgb` becomes a purely linear variant of sRGB and the types for encoded sRGB and gamma RGB can be found in a newly added `pixel` module. The `RgbPixel` trait has also been moved to the `pixel` module. The `linear_*` prefix has also been dropped from the `Rgb` constructors and some bugs from #18 were fixed as a bonus. This is a breaking change, since it moves, removes and renames a lot of functions, and the `RgbPixel` trait is no longer available in the crate root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #7 by adding separate types for sRGB and gamma encoded RGB.
Rgbbecomes a purely linear variant of sRGB and the types for encoded sRGB and gamma RGB can be found in a newly addedpixelmodule. TheRgbPixeltrait has also been moved to thepixelmodule.The
linear_*prefix has also been dropped from theRgbconstructors and some bugs from #18 were fixed as a bonus.This is a breaking change, since it moves, removes and renames a lot of functions, and the
RgbPixeltrait is no longer available in the crate root.