Fix or relax some color ranges and clamping #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@homu r+ |
|
📌 Commit b7dd6ae has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Jan 28, 2016
Fix or relax some color ranges and clamping The `ColorSpace` trait has been repurposed as a trait for checking limits and clamping, and is now called `Limited`. The limits of `Xyz` has been changed to use the white point as its maximum (closing #10), and the maximum of `Lch.chroma` has been removed, since it's not very well defined. The ranges of `Lch` stays as they are, for the sake of consistency. Extra clamping is also added when converting RGB colors to `u8` based pixel representation, to prevent float shenanigans when multiplying values with 255.0. It's impossible to know what a type `T` will do when it's asked to convert `255.12312312` or whatever to `u8`. This closes #19. This is a breaking change, since it changes the ranges of some color spaces and renames the `ColorSpace` trait to `Limited`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ColorSpacetrait has been repurposed as a trait for checking limits and clamping, and is now calledLimited. The limits ofXyzhas been changed to use the white point as its maximum (closing #10), and the maximum ofLch.chromahas been removed, since it's not very well defined. The ranges ofLchstays as they are, for the sake of consistency.Extra clamping is also added when converting RGB colors to
u8based pixel representation, to prevent float shenanigans when multiplying values with 255.0. It's impossible to know what a typeTwill do when it's asked to convert255.12312312or whatever tou8. This closes #19.This is a breaking change, since it changes the ranges of some color spaces and renames the
ColorSpacetrait toLimited.