Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent dev dependencies from breaking tests and examples #349

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

Ogeon
Copy link
Owner

@Ogeon Ogeon commented Aug 21, 2023

Make it so examples build and CI can run with a couple of temporary fixes.

  • Pins ron, since they bumped the MSRV in 0.8.1.
  • Enables the srd feature for clap, since it's required in 3.2.25.

Fixes #348

@Ogeon Ogeon added the internal An internal change that will not be shown in release notes label Aug 21, 2023
@Ogeon
Copy link
Owner Author

Ogeon commented Aug 21, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 21, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit c70d8a6 into master Aug 21, 2023
15 checks passed
@bors bors bot deleted the dev_dependency_fixes branch August 21, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal change that will not be shown in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testing examples fail with clap v3.2.25
1 participant