Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid recursive trait resolution for IntoIterator #380

Merged
merged 4 commits into from
Feb 25, 2024

Conversation

Ogeon
Copy link
Owner

@Ogeon Ogeon commented Feb 18, 2024

A workaround for another case of #283. This time for IntoIterator. It avoids the issue by only providing implementations for specific collection types.

Closed Issues

Breaking Change

This makes IntoIterator no longer generic over the collection type, but explicitly covers [T; N], &[T], &mut [T] , Vec<T>, and Box<[T]>.

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: Patch coverage is 96.56250% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 81.82%. Comparing base (7e446ea) to head (ce86a27).
Report is 4 commits behind head on master.

Files Patch % Lines
palette/src/macros/struct_of_arrays.rs 96.39% 21 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   81.21%   81.82%   +0.61%     
==========================================
  Files         113      113              
  Lines       17822    18068     +246     
  Branches    17822    18068     +246     
==========================================
+ Hits        14474    14785     +311     
+ Misses       3190     3125      -65     
  Partials      158      158              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 18, 2024

CodSpeed Performance Report

Merging #380 will degrade performances by 20.49%

⚠️ No base runs were found

Falling back to comparing issue_283_into_iterator (ce86a27) with master (25ca8af)

Summary

❌ 1 (👁 1) regressions
✅ 44 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master issue_283_into_iterator Change
👁 matrix_inverse 215.6 ns 271.1 ns -20.49%

@Ogeon Ogeon force-pushed the issue_283_into_iterator branch 2 times, most recently from 5b64581 to 9bdcd24 Compare February 24, 2024 15:21
@Ogeon Ogeon marked this pull request as ready for review February 25, 2024 11:36
@Ogeon Ogeon changed the title Avoid recursive trait resolution for IntoIterator Avoid recursive trait resolution for IntoIterator Feb 25, 2024
@Ogeon Ogeon merged commit 25ca8af into master Feb 25, 2024
16 of 17 checks passed
@Ogeon Ogeon deleted the issue_283_into_iterator branch February 25, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation error when trying to use palette
1 participant