Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traits for color schemes from traditional color theory #384

Merged
merged 3 commits into from
Mar 31, 2024

Conversation

Ogeon
Copy link
Owner

@Ogeon Ogeon commented Mar 17, 2024

This adds traits for the complementary, split complementary, analogous, triadic and tetradic color schemes. A trait for the complementary color was requested in #383, but all of these may be useful.

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 82.52033% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 81.94%. Comparing base (c54efbd) to head (479beec).

Files Patch % Lines
palette/src/macros/color_theory.rs 76.00% 24 Missing ⚠️
palette/src/serde/alpha_serializer.rs 24.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
+ Coverage   81.82%   81.94%   +0.12%     
==========================================
  Files         113      115       +2     
  Lines       18068    18277     +209     
  Branches    18068    18277     +209     
==========================================
+ Hits        14785    14978     +193     
- Misses       3125     3141      +16     
  Partials      158      158              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Mar 17, 2024

CodSpeed Performance Report

Merging #384 will improve performances by 11.42%

Comparing color_theory (479beec) with master (c54efbd)

Summary

⚡ 1 improvements
✅ 44 untouched benchmarks

Benchmarks breakdown

Benchmark master color_theory Change
matrix_inverse 271.1 ns 243.3 ns +11.42%

@Ogeon Ogeon merged commit bbd6d4b into master Mar 31, 2024
17 checks passed
@Ogeon Ogeon deleted the color_theory branch April 27, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant