Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/timelog del confirmation #234

Merged
merged 6 commits into from
Mar 26, 2024
Merged

Fix/timelog del confirmation #234

merged 6 commits into from
Mar 26, 2024

Conversation

Regularmute
Copy link
Contributor

Closes #201

  • New, reusable component ConfirmationDialog created to enable confirmation messages
  • User is prompted to confirm their choice when trying to delete a time log entry
  • Test created to check that the confirmation window works and prevents deletion when user cancels their decision
  • Existing test updated to account for the confirmation window when deleting a time log entry

miahro
miahro approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@miahro miahro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@miahro miahro merged commit 3080980 into main Mar 26, 2024
3 checks passed
@miahro miahro deleted the fix/timelog_del_confirmation branch March 26, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miahro miahro miahro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timelogs front validointi: Tuntien poistamisesta kysytään varmistus
4 participants
@Regularmute @miahro @RedFoxFinn @mluukkai