1.3-beta6 #28
Merged
1.3-beta6 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Degrees F to C conversion before uploading sensors data - Sanity check for sensors values
…lidate_measurement` for validating measurements. - Added unit tests for `get_supported_state_value` covering various scenarios for different device classes and units of measurement. - Added more debug logging for better visibility.
Olen
reviewed
Sep 2, 2024
| unit_of_measurement = "°C" | ||
|
|
||
| # Convert Kelvin to Celsius | ||
| elif unit_of_measurement == "K": |
There was a problem hiding this comment.
Thanks for reviewing the code, mate. It is just "K" as per:
Temperature units
class UnitOfTemperature(StrEnum):
"""Temperature units."""
CELSIUS = "°C"
FAHRENHEIT = "°F"
KELVIN = "K"
`
|
I have just refactored this to HASS constants to be perfect :) |
|
Just hold on merging it. It seems that there is an issue. |
- Extra DEBUG logging for visibility
|
I fixed the issue within json_timeseries library. Please merge. |
|
Hey @Olen . Just wanted to follow-up on this PR. Can you please merge as soon as possible? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge.