Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor log.fnl to remove aniseed nvim module #634

Closed
wants to merge 1 commit into from

Conversation

saccarosium
Copy link
Contributor

Hi,
this PR refactors log.fnl to use neovim builtin api instead of using aniseed nvim module.

@saccarosium
Copy link
Contributor Author

This needs a bit more cooking.

@Olical
Copy link
Owner

Olical commented Dec 31, 2024

Fair enough! Cook away and have a nice new year. And ask away if you have questions about issues you saw, I was going to look at merging this today or tomorrow before it was closed.

@saccarosium
Copy link
Contributor Author

Hey, have nice new year too! I've had some regressions that I didn't notice at first so I need to make look into that further.

I was thinking that the main thing to refactor, at least for my point of view, is a lot of the aniseed cruft and try to use as much as possible the built in APIs. This should make things more appreciable and clear to maintain and to read to newcommers. I think a good goal should be to reduce the learning curve for new contributors and hackers of the code to be able to just use their existing neovim API knowledge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants