Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flag to optionally consider overrides for gather-and-list as well #15

Merged
merged 1 commit into from
Jan 21, 2019
Merged

flag to optionally consider overrides for gather-and-list as well #15

merged 1 commit into from
Jan 21, 2019

Conversation

daaku
Copy link
Contributor

@daaku daaku commented Jan 15, 2019

It seems like --update already processes override-deps. This new flag allows for the default gather-and-print action to also consider override-deps in a similar fashion.

Olical
Olical requested changes Jan 20, 2019
View reviewed changes
Copy link
Owner

@Olical Olical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good other than an if over a when (I think?). I'll give it a spin once that's corrected. Thanks for the improvement!

Sorry about the slow response, I was on holiday.

src/depot/outdated.clj Outdated Show resolved Hide resolved
@daaku
Copy link
Contributor Author

daaku commented Jan 20, 2019

Not familiar with Github reviews, but just in case it didn't notify you - I updated the code to resolve the if -> when issue.

@Olical Olical merged commit e85975b into Olical:master Jan 21, 2019
@Olical
Copy link
Owner

Olical commented Jan 21, 2019

Thank you! Released in v1.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Olical Olical Olical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daaku @Olical