Update dependencies #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I updated it because I came across an issue where I had
org.clojure/tools.deps.alpha {:mvn/version "0.9.857"}
declared in a project's deps.edn.
I used the setup as per the README in my ~/.clojure/deps.edn:
:aliases {:outdated {:extra-deps {olical/depot {:mvn/version "2.0.1"}}
:main-opts ["-m" "depot.outdated.main"]}}
and I got an error:
Syntax error (FileNotFoundException) compiling at (depot/outdated/update.clj:1:1).
Could not locate clojure/tools/deps/alpha/reader__init.class,
clojure/tools/deps/alpha/reader.clj or
clojure/tools/deps/alpha/reader.cljc on classpath.
Then collected the info about it and was about to create a new issue
when I saw this issue about API change in tools.deps.alpha:
Olical#46 and kind of "got distracted"
and upgraded the dependencies, creating this PR.
But really, all I had to do was change the above alias to:
:aliases {:outdated {:replace-deps {olical/depot {:mvn/version "2.0.1"}}
:main-opts ["-m" "depot.outdated.main"]}}
NOTE: :replace-deps instead of :extra-deps.
Seeing as I'm updating the dependencies, updating it to the latest stable release of CIDER
This is to prevent the warnings: DEPRECATED: Libs must be qualified...
The example I added works, without any code change, but if the
previous example is used:
$ clojure -Sdeps '{:deps {olical/depot {:mvn/version "2.0.1"}}}' -m depot.outdated.main
Syntax error (FileNotFoundException) compiling at (depot/outdated/update.clj:1:1).
Could not locate clojure/tools/deps/alpha/reader__init.class,
clojure/tools/deps/alpha/reader.clj or clojure/tools/deps/alpha/reader.cljc on classpath.
This is how deps.edn looks:
$ cat deps.edn
{:paths ["src"]
:deps {org.slf4j/slf4j-simple {:mvn/version "1.7.29"}
org.clojure/tools.deps.alpha {:mvn/version "0.9.857"}}
:mvn/repos {"central" {:url "https://repo1.maven.org/maven2/"}
"clojars" {:url "https://repo.clojars.org/"}}}
|
Oh this is great! Thanks! I didn't see that tools.deps changed the API, I'm guessing it's more than just a name change, I'll take a look. |
|
Repo yak shaving complete, version published to clojars! v2.1.0 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated it because I came across an issue where I had
declared in a project's deps.edn.
I used the setup as per the README in my ~/.clojure/deps.edn:
:aliases {:outdated {:extra-deps {olical/depot {:mvn/version "2.0.1"}} :main-opts ["-m" "depot.outdated.main"]}}and I got an error:
Then collected the info about it and was about to create a new issue
when I saw this issue about API change in tools.deps.alpha:
#46 and kind of "got distracted" and upgraded the dependencies,
creating this PR.
But really, all I had to do was change the above alias to:
:aliases {:outdated {:replace-deps {olical/depot {:mvn/version "2.0.1"}} :main-opts ["-m" "depot.outdated.main"]}}NOTE:
:replace-depsinstead of:extra-deps.Then I updated more dependencies and fully qualified existing artifacts to suppress warnings.