Skip to content

Commit

Permalink
Propagate common flag to autolinked libraries (facebook#34853)
Browse files Browse the repository at this point in the history
Summary:
I'm handling this TODO i left to unbreak the CI.
We need to make sure all the autolinked libraries are getting the folly flags and other common flags propagated correctly.

## Changelog

[Internal] [Change] - Propagate common flag to autolinked libraries

Pull Request resolved: facebook#34853

Test Plan: Will rely on a green CI

Reviewed By: cipolleschi

Differential Revision: D40055134

Pulled By: cortinico

fbshipit-source-id: fb9afab954ab402f6a3ab417aba934035580f936
  • Loading branch information
cortinico authored and OlimpiaZurek committed May 22, 2023
1 parent 719a3df commit b0e97c1
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions ReactAndroid/cmake-utils/ReactNative-application.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ target_link_libraries(ReactAndroid::react_codegen_rncore INTERFACE common_flags)
if(EXISTS ${PROJECT_BUILD_DIR}/generated/rncli/src/main/jni/Android-rncli.cmake)
include(${PROJECT_BUILD_DIR}/generated/rncli/src/main/jni/Android-rncli.cmake)
target_link_libraries(${CMAKE_PROJECT_NAME} ${AUTOLINKED_LIBRARIES})
# TODO Re-link autlinking libraries against common_flags
# target_link_libraries(${AUTOLINKED_LIBRARIES} PRIVATE common_flags)
foreach(autolinked_library ${AUTOLINKED_LIBRARIES})
target_link_libraries(autolinked_library INTERFACE common_flags)
endforeach()
endif()

0 comments on commit b0e97c1

Please sign in to comment.