Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization develop to develop #271

Merged
merged 91 commits into from
Jul 26, 2023
Merged

Optimization develop to develop #271

merged 91 commits into from
Jul 26, 2023

Conversation

kathy-nevola
Copy link
Contributor

Title: Move Optimization changes to develop for new version

Problem: Write a description of your problem here.

Solution: Write a short summary of your solution.

Key Features:

  • Key feature 1
  • Key feature 2
  • ...

Checklist

  • Make sure you are requesting to pull a feature/bugfix branch (right side). This should not be main or develop.
  • Make sure you are make a pull request against either main or develop (left side). (Requesting to main should be reserved for bugfixes and new releases)
  • Add or update unit tests (if applicable)
  • Check your code with any unit tests (Run devtools::check() locally)
  • Add neccessary documentation (if applicable)

Type of changes

What type of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue) (link the issue on the right)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update (formatting, renaming)
  • Documentation Update
  • Other (explain)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, any questions you have, etc...

Consider linking any issues (#issue-number ) or adding @mentions to ensure specific people see it.

@kathy-nevola kathy-nevola added the help wanted Extra attention is needed label Jul 20, 2023
@klevdiamanti klevdiamanti self-requested a review July 21, 2023 13:18
Copy link
Contributor

@klevdiamanti klevdiamanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kathy-nevola kathy-nevola merged commit 589e180 into develop Jul 26, 2023
@klevdiamanti klevdiamanti deleted the optimization_develop branch November 23, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants