Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI workflows #338

Merged

Conversation

klevdiamanti
Copy link
Contributor

Title: Update CI workflows

Problem: Our CI workflows need to be updated and some new ones for stricter checking should be added.

Solution: Check https://github.com/r-lib/actions/ foe updates and make sure that we have updated and correct CI workdlows.

Checklist

  • Make sure you are requesting to pull a feature/bugfix branch (right side). This should not be main or develop.
  • Make sure you are make a pull request against either main or develop (left side). (Requesting to main should be reserved for bugfixes and new releases)
  • Add or update unit tests (if applicable)
  • Check your code with any unit tests (Run devtools::check() locally)
  • Add neccessary documentation (if applicable)

Type of changes

What type of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue) (link the issue on the right)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update (formatting, renaming)
  • Documentation Update
  • Improved CI

@klevdiamanti klevdiamanti added the enhancement New feature or request label Mar 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (052c9cb) to head (e1d9b76).

❗ Current head e1d9b76 differs from pull request most recent head 1ad3dbe. Consider uploading reports for the commit 1ad3dbe to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           optimization_develop     #338   +/-   ##
=====================================================
  Coverage                 99.88%   99.88%           
=====================================================
  Files                        20       20           
  Lines                      1807     1807           
=====================================================
  Hits                       1805     1805           
  Misses                        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@klevdiamanti klevdiamanti merged commit a601f46 into optimization_develop Mar 15, 2024
15 checks passed
@klevdiamanti klevdiamanti deleted the optimization_develop_strict_ci_workflow branch March 15, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants