Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extruder calculation with G2/G3 #182

Closed
wants to merge 2 commits into from
Closed

Conversation

ldursw
Copy link

@ldursw ldursw commented Jun 2, 2021

When using this plugin with Arc Welder the extruded filament on arc moves was not calculated causing the final value to be lower than what the firmware reported.

This PR is a port from OllisGit/OctoPrint-FilamentManager#67 to SpoolManager.

@OllisGit OllisGit added the status: inNextRelease Will be implemented/fixed in next release label Jun 4, 2021
@OllisGit
Copy link
Owner

OllisGit commented Jun 4, 2021

Thanks a lot for the merge requests, I really appreciate that.

The newodometer.py was a copy of gcodeinterpreter.py Version OP 1.5.2.
I looked into the current implementation and I think the arc-movement is also not tracked yet.

https://github.com/OctoPrint/OctoPrint/blob/master/src/octoprint/util/gcodeInterpreter.py#L420

Did you also raise an issue in OP tracker?

@ldursw
Copy link
Author

ldursw commented Jun 4, 2021

I'll open an issue there. Thanks for pointing out.

@OllisGit OllisGit removed the status: inNextRelease Will be implemented/fixed in next release label Oct 24, 2021
@bcat
Copy link

bcat commented Dec 14, 2021

It looks like this is fixed in upstream OctoPrint now: OctoPrint/OctoPrint@b60c109. I can confirm that OctoPrint 1.7.2 shows the correct filament usage for a G-code file with arc moves. (In my case, I use the ArcWelder Cura plugin, so I don't have ArcWelder installed in OctoPrint, but the effect is the same.)

I just started using SpoolManager last night, and I haven't actually finished my first print with it yet, but it sounds like it will undercount the arc moves vs. what OctoPrint shows? (I can confirm that when this print finishes tomorrow, if that's useful.)

@OllisGit
Copy link
Owner

Hi l@dursw,
sorry I missed your PR to include in the last release 1.6.0.

I compared the OP-Implementation with your PR and is still valid, so your PR will be in the next release (not planed yet).

@OllisGit OllisGit added the status: inNextRelease Will be implemented/fixed in next release label Jan 13, 2022
@OllisGit
Copy link
Owner

It took a while, but it is in the latest RC 1.7.0rc1.

@dursw, Thanks again!

@OllisGit OllisGit closed this Feb 17, 2022
@codingcatgirl
Copy link
Contributor

Oh hey that's great news! I was about to ask for this, thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: inNextRelease Will be implemented/fixed in next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants