Code coverage it #183
Merged
Code coverage it #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update testcontainers version to 1.19.1. Update use of compose to Docker Compose V2. Refactor integration tests.
Add profile for integration tests with Docker. Add use of Maven failsafe plugin.
Add code coverage for integration tests with Docker. By default, code coverage is disabled.
JUnit5 test classes and methods should have default package visibility
Unnecessary imports should be removed
Lambdas containing only one statement should not nest this statement in a block
Modifiers should be declared in the correct order
Printf-style format strings should be used correctly
Ensure consistent handling of loggers and log levels. Invoke log formatting conditionally. Collect log texts and use formatted strings in logging.
Add integration tests for search endpoint for logs.
Update testcontainers version to 1.19.3.
georgweiss
reviewed
Dec 14, 2023
|
To build and run all unit tests and integration tests (Docker) with code coverage
More information is available in README.md, section Integration tests with Docker containers, that points to How to run and Tutorial. |
georgweiss
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repair and refactor integration tests with Docker containers.
Add code coverage.
Welcome to have a look!