Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle display of very many passwords #78

Merged
merged 10 commits into from
Jul 2, 2023
Merged

Handle display of very many passwords #78

merged 10 commits into from
Jul 2, 2023

Conversation

techmaved
Copy link
Contributor

Motivation

So our page doesn't really can handle loads of passwords, so a #74 (Paginator) was needed.

Changes

Tests done

Selected pages and checked shown passwords

TODO

  • I've assigned this PR to myself
  • I've labeled this PR correctly

@techmaved techmaved added the feature New feature or request label Jun 28, 2023
@techmaved techmaved requested a review from Fovty June 28, 2023 18:34
@techmaved techmaved self-assigned this Jun 28, 2023
@techmaved techmaved marked this pull request as draft June 28, 2023 18:41
@techmaved techmaved changed the title Handling of lots of passwords Handle display of very many passwords Jun 28, 2023
@techmaved techmaved marked this pull request as ready for review June 29, 2023 06:54
@lvlcn-t
Copy link
Collaborator

lvlcn-t commented Jun 30, 2023

does the paginator also work if you use the search bar?

@techmaved
Copy link
Contributor Author

does the paginator also work if you use the search bar?

No not yet

@techmaved
Copy link
Contributor Author

does the paginator also work if you use the search bar?

Now it does

lvlcn-t
lvlcn-t reviewed Jul 1, 2023
View reviewed changes
db.php Show resolved Hide resolved
public/js/overview.js Outdated Show resolved Hide resolved
@techmaved techmaved merged commit 5d624f9 into main Jul 2, 2023
1 check passed
@techmaved techmaved deleted the feat/pagination branch July 2, 2023 07:34
@techmaved techmaved mentioned this pull request Jul 2, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvlcn-t lvlcn-t lvlcn-t approved these changes

@Fovty Fovty Awaiting requested review from Fovty

Assignees

@techmaved techmaved

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@techmaved @lvlcn-t