Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Djot extension for symbol-based conditionals #93

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

Omikhleia
Copy link
Owner

@Omikhleia Omikhleia commented Aug 19, 2023

Initially an experimental proposal.

Refer to jgm/djot#238

Moving forward:
Needing some minimal templating strategy for resilient.sile v2.2 "bookmatter" feature, and this is sound enough to start with.

@Omikhleia Omikhleia marked this pull request as draft August 19, 2023 18:43
@Omikhleia Omikhleia added the enhancement New feature or request label Aug 21, 2023
@Omikhleia Omikhleia force-pushed the feat-conditionals-djot-extension-experimental branch from c301f36 to be10436 Compare September 3, 2023 14:53
That is immediately following the div, `::: xxxx`, for two reasons
- We cannot use more than one class attribute there for now, so
  conditionals here are awkward
- There are sound discussions on the Djot forum for evolving
  towards some kind of "tag" rather than a class here.
Overall, we don't need the extra complexity, having conditionals
in the attribute syntax before the div is sufficient, and make
things simpler if we eventually move to a pre-pass rather than
directly hack the Djot reader.
@Omikhleia Omikhleia added this to the 1.5.0 milestone Sep 4, 2023
@Omikhleia Omikhleia marked this pull request as ready for review September 4, 2023 11:39
@Omikhleia Omikhleia merged commit 230ed67 into main Sep 4, 2023
2 checks passed
@Omikhleia Omikhleia deleted the feat-conditionals-djot-extension-experimental branch September 4, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant