Move registration options to the descriptor #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bjorkstromm
commented
Jul 19, 2019
bjorkstromm
commented
- Fixes issue where clients that doesn't support dynamic registrations will not end up with the correct handler matching the document (due to that registration is null). See OmniSharp-Roslyn issues [LSP] Failed to handle request textDocument/didChange omnisharp-roslyn#1505 and LSP Mode does not seem to work with OmniSharp Client omnisharp-roslyn#1525
- Fixes issue where clients that doesn't support dynamic registrations will not end up with the correct handler matching the document (due to that registration is null). See OmniSharp-Roslyn issue #1505 and #1525
bjorkstromm
commented
Jul 19, 2019
| @@ -13,7 +13,7 @@ | |||
| <PackageReference Include="Microsoft.Extensions.DependencyInjection" /> | |||
| <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" /> | |||
| <PackageReference Include="Newtonsoft.Json" /> | |||
| <Compile Include="../../submodules/MediatR/src/MediatR/**/*.cs" Exclude="**/AssemblyInfo.cs" Visible="false" /> | |||
| <Compile Include="../../submodules/MediatR.Extensions.Microsoft.DependencyInjection/src/MediatR.Extensions.Microsoft.DependencyInjection/**/*.cs" Exclude="**/AssemblyInfo.cs" Visible="false" /> | |||
| <Compile Include="../../submodules/MediatR/src/MediatR/**/*.cs" Exclude="**/*AssemblyInfo.cs" Visible="false" /> | |||
There was a problem hiding this comment.
For some reason, when source including from OmniSharp-Roslyn, VS will go and restore the embedded MediatR, making it pickup a generated Assembly Info from obj folder. This fixes that.
| @@ -15,16 +15,16 @@ export function activate(context: ExtensionContext) { | |||
|
|
|||
| // The server is implemented in node | |||
| // let serverExe = 'dotnet'; | |||
| let serverExe = 'D:\\development\\omnisharp\\omnisharp-roslyn\\bin\\Debug\\OmniSharp.Stdio.Driver\\net461\\OmniSharp.exe'; | |||
| let serverExe = 'C:/Users/mb/src/gh/omnisharp-roslyn/artifacts/publish/OmniSharp.Stdio.Driver/win7-x64/OmniSharp.exe'; | |||
There was a problem hiding this comment.
Oops, I'll remove these.
…ation and create the registrations on demand as needed
This was referenced Jul 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.