Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced override completion. #1577

Closed

Conversation

kurobon-jp
Copy link
Contributor

Hello.
I am not satisfied with the omnisharp override completion feature.
So i added the funcution to provide method implementations from the override completion list.
I would like to get your feedback on this.
override

@filipw
Copy link
Member

filipw commented Aug 6, 2019

thanks a lot for the PR - however we will be implementing this differently.

The way to go forward will be to use completion service from Roslyn fully. Once the completion service is properly consumed on the server side, we'll be able to offer a new general purpose resolve endpoint that will take care of not only override improvements but many other things VS does now like importing extra namespaces on completion etc. This was initiated in #884 and I also have a private branch I've been working on to move this forward.

Thanks again for your suggestion though.

@filipw
Copy link
Member

filipw commented Aug 6, 2019

cc @david-driscoll

@kurobon-jp
Copy link
Contributor Author

Thank you for telling me.
I hope it will be released soon.

@kurobon-jp kurobon-jp closed this Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants