New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make platform identification POSIX-compliant #1651

Merged

filipw merged 1 commit into OmniSharp:master from felschr:patch-1

Nov 15, 2019

Contributor

felschr commented Nov 13, 2019

On certain POSIX systems /bin/bash might not be available.
For example on NixOS the following error message appears wen running omnisharp:

Failed to launch '/bin/bash' with args, '-c 'uname -s -m''
{"Event":"log","Body":{"LogLevel":"INFORMATION","Name":"OmniSharp.Stdio.Host","Message":"Starting OmniSharp on Unknown 0.0 (Unknown)"},"Seq":1,"Type":"event"}

This I propose changing the command to use /bin/sh which should be available on more POSIX-compliant OSes including macOS.


          make platform identification POSIX-compliant

2e37c48

filipw approved these changes

View reviewed changes

Member

filipw left a comment

very good - thanks a lot

filipw merged commit 9544671 into OmniSharp:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet