Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Roslyn to 4.3.0-3.22329.4 #2416

Closed

Conversation

JoeRobich
Copy link
Member

@filipw filipw enabled auto-merge June 29, 2022 04:24
@JoeRobich JoeRobich changed the title Update Roslyn to 4.3.0-3.22328.9 Update Roslyn to 4.3.0-3.22329.4 Jun 29, 2022
@filipw
Copy link
Member

filipw commented Jul 5, 2022

Thanks for tackling the line normalizations, I can imagine how annoying this must 🙈
there still appear to be 2 failures related to that:

  Failed OmniSharp.Roslyn.CSharp.Tests.CompletionFacts.TestOverrideWithTrailingWhitespacePrior(filename: "dummy.cs") [27 ms]
4683
  Error Message:
4684
   Assert.Equal() Failure
4685
          ↓ (pos 0)
4686
Expected: \n        // The trailing tabs on the prev···
4687
Actual:           // The trailing tabs on the previ···
4688
          ↑ (pos 0)
4689
  Stack Trace:
4690
     at OmniSharp.Roslyn.CSharp.Tests.CompletionFacts.TestOverrideWithTrailingWhitespacePrior(String filename) in /home/runner/work/omnisharp-roslyn/omnisharp-roslyn/tests/OmniSharp.Roslyn.CSharp.Tests/CompletionFacts.cs:line 2254
4691
--- End of stack trace from previous location ---
4692
  Standard Output Messages:
4693
 [trce]: OmniSharp.Roslyn.CSharp.Services.Completion.CompletionService
4694
         Completions requested
4695
 [dbug]: OmniSharp.MSBuild.ProjectSystem
4696
         Could not locate project for '/home/runner/work/omnisharp-roslyn/omnisharp-roslyn/bin/Release/OmniSharp.Roslyn.CSharp.Tests/net7.0/project.csproj'
4697
 [trce]: OmniSharp.Roslyn.CSharp.Services.Completion.CompletionService
4698
         Found 3 completions for dummy.cs:7,17
4699
 [trce]: OmniSharp.Roslyn.CSharp.Services.Completion.CompletionService
4700
         Completions filled in
4701
4702
4703
  Failed OmniSharp.Roslyn.CSharp.Tests.CompletionFacts.TestOverrideWithTrailingWhitespacePrior(filename: "dummy.csx") [57 ms]
4704
  Error Message:
4705
   Assert.Equal() Failure
4706
          ↓ (pos 0)
4707
Expected: \n        // The trailing tabs on the prev···
4708
Actual:           // The trailing tabs on the previ···
4709
          ↑ (pos 0)
4710
  Stack Trace:
4711
     at OmniSharp.Roslyn.CSharp.Tests.CompletionFacts.TestOverrideWithTrailingWhitespacePrior(String filename) in /home/runner/work/omnisharp-roslyn/omnisharp-roslyn/tests/OmniSharp.Roslyn.CSharp.Tests/CompletionFacts.cs:line 2254

@JoeRobich
Copy link
Member Author

I think I need to scrap this and start over. I believe the problem is with the O# implementation of ILegacyGlobalOptionsWorkspaceService that I added to Roslyn. I let it take all defaults because I didn't expect a lot of things to still be using the Legacy options, however, I see where it could be inheriting Environment.NewLine as its NewLine character instead of taking the appropriate formatting option.

@JoeRobich
Copy link
Member Author

Superseded by #2420

@JoeRobich JoeRobich closed this Jul 19, 2022
auto-merge was automatically disabled July 19, 2022 23:07

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some problems occurred when opening razor in VScode
2 participants