-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Roslyn to 4.3.0-3.22329.4 #2416
Update Roslyn to 4.3.0-3.22329.4 #2416
Conversation
…/omnisharp-roslyn into update-roslyn-4.3.0-2.22307.14
Thanks for tackling the line normalizations, I can imagine how annoying this must 🙈
|
I think I need to scrap this and start over. I believe the problem is with the O# implementation of ILegacyGlobalOptionsWorkspaceService that I added to Roslyn. I let it take all defaults because I didn't expect a lot of things to still be using the Legacy options, however, I see where it could be inheriting Environment.NewLine as its NewLine character instead of taking the appropriate formatting option. |
Superseded by #2420 |
Pull request was closed
Fixes dotnet/vscode-csharp#5248