Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Roslyn to 4.4.0 1.22369.1 #2420

Merged
merged 14 commits into from
Jul 25, 2022
Merged

Update Roslyn to 4.4.0 1.22369.1 #2420

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e3d1c35
Update Roslyn to 4.4.0-1.22369.1
JoeRobich Jul 19, 2022
ad6207c
Merge remote-tracking branch 'origin/master' into update-roslyn-4.4.0…
JoeRobich Jul 19, 2022
1de00dd
Update changelog
JoeRobich Jun 29, 2022
fb1e841
Add comment
JoeRobich Jul 19, 2022
4b21028
Update changelog
JoeRobich Jul 19, 2022
ea4f75b
updated test to csharp11
filipw Jul 20, 2022
65b3fb0
Update src/OmniSharp.Roslyn.CSharp/Services/Completion/CompletionList…
filipw Jul 20, 2022
02a47aa
Update CompletionListBuilder_Sync.cs
filipw Jul 20, 2022
eb26f15
Use a test fixture for async and import completion hosts.
333fred Jul 21, 2022
579814f
Fix race condition with multithreaded tests.
333fred Jul 21, 2022
750a244
Cache References returned by TestUtility
JoeRobich Jul 22, 2022
2e0dbd9
Revert "Fix race condition with multithreaded tests."
JoeRobich Jul 22, 2022
75c6218
Revert "Use a test fixture for async and import completion hosts."
JoeRobich Jul 22, 2022
1a517f1
Create CodeRefactoringContext with Options.
JoeRobich Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OmniSharp.Roslyn.CSharp/Services/Completion/CompletionListBuilder_Sync.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ internal static partial class CompletionListBuilder
completionTasksAndProviderNamesBuilder.Add(((Task<CompletionChange>?)completionService.GetChangeAsync(document, completion), providerName));
}
}
var completionTasksAndProviderNames = completionTasksAndProviderNamesBuilder.MoveToImmutable();
var completionTasksAndProviderNames = completionTasksAndProviderNamesBuilder.ToImmutable();
filipw marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filipw why did you revert this? Just to see if it would fix the OOM issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it failed many tests with System.InvalidOperationException : MoveToImmutable can only be performed when Count equals Capacity.


for (int i = 0; i < completions.ItemsList.Count; i++)
{
Expand Down