Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade roslyn to 4.6.0-2.23128.12 #2511

Merged
merged 6 commits into from
Mar 4, 2023
Merged

Upgrade roslyn to 4.6.0-2.23128.12 #2511

merged 6 commits into from
Mar 4, 2023

Conversation

dibarbet
Copy link
Contributor

@dibarbet dibarbet commented Mar 1, 2023

No description provided.

@dibarbet dibarbet force-pushed the upgrade_roslyn branch 2 times, most recently from d094ca4 to 0b88dd2 Compare March 1, 2023 22:46
filipw
filipw approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@filipw
Copy link
Member

filipw commented Mar 3, 2023

@dibarbet the test failures look legit:

Failed OmniSharp.Roslyn.CSharp.Tests.CompletionFacts.UsingsAddedInOrder(filename: "dummy.cs", useAsyncCompletion: False) [520 ms]
35375
Error Message:
35376
System.MissingMethodException : Method not found: 'Void Microsoft.CodeAnalysis.Completion.CompletionOptions.set_ShowItemsFromUnimportedNamespaces(System.Nullable`1)'.
35377
Stack Trace:
35378
at Microsoft.CodeAnalysis.ExternalAccess.OmniSharp.Completion.OmniSharpCompletionOptions.ToCompletionOptions()

@dibarbet
Copy link
Contributor Author

dibarbet commented Mar 3, 2023

@filipw they are indeed. Trying to fix them in dotnet/roslyn#67163

@filipw
Copy link
Member

filipw commented Mar 4, 2023

nice, thank you!

@filipw filipw merged commit bf75512 into OmniSharp:master Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipw filipw filipw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dibarbet @filipw