Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app.config to require .NET 4.6 when launching OmniSharp.exe #669

Merged
merged 1 commit into from
Nov 16, 2016

Conversation

DustinCampbell
Copy link
Contributor

This will cause a dialog to be displayed when launching OmniSharp.exe to inform the user that they need to install .NET Framework 4.6 to run it.

@DustinCampbell
Copy link
Contributor Author

Note: Without this. starting the net46 version of OmniSharp will result in the following error on machine without .NET 4.6:

Unhandled Exception: System.TypeInitializationException: The type initializer for 'System.Diagnostics.DiagnosticSourceEventSource' threw an exception. ---> System.MissingMethodException: Method not found: 'Void System.Diagnostics.Tracing.EventSource..ctor(System.Diagnostics.Tracing.EventSourceSettings)'.
at System.Diagnostics.DiagnosticSourceEventSource..ctor()
at System.Diagnostics.DiagnosticSourceEventSource..cctor()
--- End of inner exception stack trace ---
at System.Diagnostics.DiagnosticListener..ctor(String name)
at Microsoft.AspNetCore.Hosting.WebHostBuilder.BuildHostingServices()
at Microsoft.AspNetCore.Hosting.WebHostBuilder.Build()
at OmniSharp.Program.Main(String[] args) in C:\Projects\omnisharp-roslyn\src\OmniSharp.Host\Program.cs:line 143
at Program.Main(String[] args) in C:\Projects\omnisharp-roslyn\src\OmniSharp\Program.cs:line 21

This happens on Windows 8.1 with no updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants