Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade tap from 5.8.0 to 11.1.3 #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

snyk-bot
Copy link

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

merge advice

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 584/1000
Why? Has a fix available, CVSS 7.4
Regular Expression Denial of Service (ReDoS)
SNYK-JS-HAWK-2808852
Yes No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: tap The new version differs by 250 commits.
  • fe8158e 11.1.3
  • b17542d Upgrade deps (changing semver requirements)
  • bc3ba17 update deps
  • bd4de92 Clean up nyc output so Travis passes on node 6
  • 2292432 Add hexagonal-lambda to the tap 100 list
  • fed62c9 Merge remote-tracking branch 'origin/master'
  • 3cdf1c7 11.1.2
  • ddf938b Only ship files we want to ship
  • 5b5e2ee docs: add unique page titles
  • 2323c3b Merge tag 'v11.1.1'
  • 95faf6c 11.1.1
  • 283c8e6 Handle EPIPE better in exceptional edge cases
  • b727234 Fix obscure edge case when this.results is not set
  • 1699eb9 process: update docs on the master branch
  • ac366a0 docs: fix typo ('heirarchical' -> 'hierarchical')
  • 13073a7 docs: correct 100 PR link
  • b95ee22 v11.1.0
  • fcf70aa Add support for disabling autoend
  • 94be0a7 v11.0.1
  • 6c3f019 remove badges that are no longer accurate or in use
  • ae562a7 don't ignore coverage doc
  • 9fcfd52 Migrate docs into main repository
  • f189c50 v11.0.0
  • 5cde128 Merge branch 'v11'

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-HAWK-2808852
Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Jit has detected 29 important findings in this PR that you should review.
The findings are detailed below as separate comments.
It’s highly recommended that you fix these security issues before merge.

@@ -10,6 +10,6 @@
"dependencies": {
"node-uuid": "1.4.0",
"qs": "0.0.6",
"tap": "^5.8.0"
"tap": "^11.1.3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Software Component Analysis Js

Type: Arbitrary Code Execution In Handlebars

Description: tap>nyc>istanbul-reports>handlebars@4.0.11

Severity: HIGH

Learn more about this issue


Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_finding Ignore this specific single instance of finding
  • #jit_undo_ignore Undo ignore command

@@ -10,6 +10,6 @@
"dependencies": {
"node-uuid": "1.4.0",
"qs": "0.0.6",
"tap": "^5.8.0"
"tap": "^11.1.3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Software Component Analysis Js

Type: Arbitrary Code Execution In Handlebars

Description: tap>nyc>istanbul-reports>handlebars@4.0.11

Severity: HIGH

Learn more about this issue


Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_finding Ignore this specific single instance of finding
  • #jit_undo_ignore Undo ignore command

@@ -10,6 +10,6 @@
"dependencies": {
"node-uuid": "1.4.0",
"qs": "0.0.6",
"tap": "^5.8.0"
"tap": "^11.1.3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Software Component Analysis Js

Type: Prototype Pollution In Minimist

Description: _Paths from library to vulnerable dependencies:

  • tap>nyc>mkdirp>minimist@0.0.8
  • tap>nyc>caching-transform>mkdirp>minimist@0.0.8
  • tap>nyc>istanbul-reports>handlebars>optimist>minimist@0.0.8_

Severity: HIGH

Learn more about this issue


Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_finding Ignore this specific single instance of finding
  • #jit_undo_ignore Undo ignore command

@@ -10,6 +10,6 @@
"dependencies": {
"node-uuid": "1.4.0",
"qs": "0.0.6",
"tap": "^5.8.0"
"tap": "^11.1.3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Software Component Analysis Js

Type: Remote Code Execution In Handlebars When Compiling Templates

Description: tap>nyc>istanbul-reports>handlebars@4.0.11

Severity: HIGH

Learn more about this issue


Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_finding Ignore this specific single instance of finding
  • #jit_undo_ignore Undo ignore command

@@ -10,6 +10,6 @@
"dependencies": {
"node-uuid": "1.4.0",
"qs": "0.0.6",
"tap": "^5.8.0"
"tap": "^11.1.3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Software Component Analysis Js

Type: Denial Of Service In Handlebars

Description: tap>nyc>istanbul-reports>handlebars@4.0.11

Severity: MEDIUM

Learn more about this issue


Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_finding Ignore this specific single instance of finding
  • #jit_undo_ignore Undo ignore command

@@ -10,6 +10,6 @@
"dependencies": {
"node-uuid": "1.4.0",
"qs": "0.0.6",
"tap": "^5.8.0"
"tap": "^11.1.3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Software Component Analysis Js

Type: Regular Expression Denial Of Service (Redos) In Lodash

Description: _Paths from library to vulnerable dependencies:

  • tap>nyc>istanbul-lib-instrument>babel-types>lodash@4.17.10
  • tap>nyc>istanbul-lib-instrument>babel-generator>babel-types>lodash@4.17.10
  • tap>nyc>istanbul-lib-instrument>babel-template>babel-traverse>babel-types>lodash@4.17.10_

Severity: MEDIUM

Learn more about this issue


Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_finding Ignore this specific single instance of finding
  • #jit_undo_ignore Undo ignore command

@@ -10,6 +10,6 @@
"dependencies": {
"node-uuid": "1.4.0",
"qs": "0.0.6",
"tap": "^5.8.0"
"tap": "^11.1.3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Software Component Analysis Js

Type: Prototype Pollution In Handlebars

Description: tap>nyc>istanbul-reports>handlebars@4.0.11

Severity: HIGH

Learn more about this issue


Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_finding Ignore this specific single instance of finding
  • #jit_undo_ignore Undo ignore command

@@ -10,6 +10,6 @@
"dependencies": {
"node-uuid": "1.4.0",
"qs": "0.0.6",
"tap": "^5.8.0"
"tap": "^11.1.3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Software Component Analysis Js

Type: Regular Expression Denial Of Service In Handlebars

Description: tap>nyc>istanbul-reports>handlebars@4.0.11

Severity: HIGH

Learn more about this issue


Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_finding Ignore this specific single instance of finding
  • #jit_undo_ignore Undo ignore command

@@ -10,6 +10,6 @@
"dependencies": {
"node-uuid": "1.4.0",
"qs": "0.0.6",
"tap": "^5.8.0"
"tap": "^11.1.3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Software Component Analysis Js

Type: Prototype Pollution In Handlebars

Description: tap>nyc>istanbul-reports>handlebars@4.0.11

Severity: HIGH

Learn more about this issue


Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_finding Ignore this specific single instance of finding
  • #jit_undo_ignore Undo ignore command

@@ -10,6 +10,6 @@
"dependencies": {
"node-uuid": "1.4.0",
"qs": "0.0.6",
"tap": "^5.8.0"
"tap": "^11.1.3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Software Component Analysis Js

Type: Regular Expression Denial Of Service In Path-Parse

Description: tap>nyc>istanbul-lib-report>path-parse@1.0.5

Severity: MEDIUM

Learn more about this issue


Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_finding Ignore this specific single instance of finding
  • #jit_undo_ignore Undo ignore command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant