EIP-7512: Text Updates + Corrections #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmeissner
reviewed
Sep 22, 2023
| - `auditHash` - MUST be the hash of the original audit. This allows to verify that this onchain information belongs to a specific audit. | ||
| - `auditUri` - SHOULD point to a source where the audit can be retrieved | ||
| - `auditor`: Information on the auditor | ||
| - `auditedContract`: MUST be the `chainId` as well as `deployment` of the contract the audit is related to |
There was a problem hiding this comment.
Note: this was changed as contract is a keyword in solidity
There was a problem hiding this comment.
same for address to deployment
rmeissner
reviewed
Sep 22, 2023
| Needs discussion. | ||
| ### Auditor Key Management | ||
|
|
||
| The premise of this ERC relies on proper key management by the auditors who partake in the system. If an auditor's key is compromised, they may be associated with seemingly audited or ERC-compliant contracts that ultimately could not comply with the standards. As a potential protection measure, the ERC may define an "association" of auditors (f.e. auditing companies) that would permit a secondary key to revoke existing signatures of auditors as a secondary security measure in case of an auditor's key compromise. |
rmeissner
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR that includes multiple text changes, corrections, and essentially includes all content of #2 without any mention of proxy/polymorphism support.