Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Fix the hadolint errors 🧪 #326

Open
jbampton opened this issue Apr 23, 2022 · 1 comment
Open

🧪 Fix the hadolint errors 🧪 #326

jbampton opened this issue Apr 23, 2022 · 1 comment

Comments

@jbampton
Copy link
Contributor

pre-commit now requires Docker to run the hadolint hook

Dockerfile:1 DL3007 warning: Using latest is prone to errors if the image will ever update. Pin the version explicitly to a release tag
Dockerfile:2 DL3048 style: Invalid label key.
Dockerfile:8 DL3018 warning: Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
Dockerfile:24 SC2016 info: Expressions don't expand in single quotes, use double quotes for that.
Dockerfile:24 DL3047 info: Avoid use of wget without progress bar. Use `wget --progress=dot:giga <url>`.Or consider using `-q` or `-nv` (shorthands for `--quiet` or `--no-verbose`).
Dockerfile:28 DL3003 warning: Use WORKDIR to switch to a directory
Dockerfile:38 SC2046 warning: Quote this to prevent word splitting.
Dockerfile:40 DL3003 warning: Use WORKDIR to switch to a directory
Dockerfile:46 DL3042 warning: Avoid use of cache directory with pip. Use `pip install --no-cache-dir <package>`
Dockerfile:46 DL3013 warning: Pin versions in pip. Instead of `pip install <package>` use `pip install <package>==<version>` or `pip install --requirement <requirements file>`
Dockerfile:54 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile:55 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile:62 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile:65 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile:66 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile:67 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile:70 DL3025 warning: Use arguments JSON notation for CMD and ENTRYPOINT arguments
@jbampton jbampton changed the title Fix the hadolint errors on pre-commit 🧪 Fix the hadolint errors on pre-commit 🧪 Apr 25, 2022
jbampton added a commit that referenced this issue Apr 26, 2022
jbampton added a commit that referenced this issue Apr 26, 2022
@jbampton jbampton changed the title 🧪 Fix the hadolint errors on pre-commit 🧪 🧪 Fix the hadolint errors 🧪 Nov 28, 2022
@jbampton
Copy link
Contributor Author

Now we just need some minor clean up

% hadolint Dockerfile                                  
Dockerfile:1 DL3007 warning: Using latest is prone to errors if the image will ever update. Pin the version explicitly to a release tag
Dockerfile:8 DL3018 warning: Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
Dockerfile:28 DL3003 warning: Use WORKDIR to switch to a directory
Dockerfile:38 SC2046 warning: Quote this to prevent word splitting.
Dockerfile:40 DL3003 warning: Use WORKDIR to switch to a directory
Dockerfile:46 DL3013 warning: Pin versions in pip. Instead of `pip install <package>` use `pip install <package>==<version>` or `pip install --requirement <requirements file>`
Dockerfile:54 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile:55 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile:62 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile:65 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile:66 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile:67 DL3059 info: Multiple consecutive `RUN` instructions. Consider consolidation.
Dockerfile:70 DL3025 warning: Use arguments JSON notation for CMD and ENTRYPOINT arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant