Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alterations to lexer #247

Merged
merged 2 commits into from
Aug 28, 2021
Merged

Alterations to lexer #247

merged 2 commits into from
Aug 28, 2021

Conversation

mikey-b
Copy link
Contributor

@mikey-b mikey-b commented Aug 28, 2021

Hi Max,

I have made the following changes to the lexer:

  • Break dependencies between modules (Error, AST, Lexer, Token etc)
  • The lexer is a sub-task of parsing, moved into parser
  • Removed tokenizer
  • Cleaned .h files
  • Changed lexer api to peekFor(), advance(), lexer_init() and lexer_free()

@mikey-b
Move Lexer
24c8d24 
Lexer is a sub-task of parsing
@mikey-b
Lexer Changes
211c02f 
Removal of tokenizer

Breaking of dependencies between modules - (error, token, ast, etc)

Change of lexer API to;
lexer_init()
peekFor()
advance()
lexer_free();
@github-actions github-actions bot added the src label Aug 28, 2021
@restyled-io restyled-io bot mentioned this pull request Aug 28, 2021
Closed
@BaseMax
Copy link
Member

BaseMax commented Aug 28, 2021

Dear Michael, Thank you so much.

@BaseMax BaseMax merged commit 8057c3a into One-Language:master Aug 28, 2021
@jbampton jbampton mentioned this pull request May 31, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BaseMax BaseMax Awaiting requested review from BaseMax

@jbampton jbampton Awaiting requested review from jbampton

Assignees
No one assigned
Labels
src
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikey-b @BaseMax