Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1007 - Call save-device-info method at application launch #1008

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

cagryInside
Copy link
Contributor

Calling the saveDeviceInfo method in the app launch. Previously, we were calling this method on every transition event and it was causing duplicate ~device-information` records on Firebase. Now, we only call once when the app is started. The new data looks like this on Firebase:

Screen Shot 2019-07-18 at 3 21 10 PM

@barbeau
Copy link
Member

barbeau commented Jul 19, 2019

Thanks @cagryInside! How about putting the timestamp as a field too so we can query on it?

@cagryInside
Copy link
Contributor Author

Thanks @cagryInside! How about putting the timestamp as a field too so we can query on it?

@barbeau good idea. Just added and updated the commit:

Screen Shot 2019-07-19 at 11 08 12 AM

@barbeau
Copy link
Member

barbeau commented Jul 29, 2019

Thanks @cagryInside!

@barbeau barbeau merged commit f8225dd into OneBusAway:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants