Fixed #1196 - Loading weather image. #1198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1196.
I used a dummy keystore to generate a release version, but it crashed when I opened the app!
The app does not detect any resId when I search for weather icons in the release version.
This method is responsible for getting an image resource from the drawable using the resource name.
int resId = context.getResources().getIdentifier(resName, "drawable", context.getPackageName());
The method worked well with the debug version, but in the release version, it's not working. It's strange, but I think the resource names may have been parsed, and their names were changed during the release version. Therefore, I used a safer function that directly calls the path of the image from a drawable resource. I have tested it in a release version, and it's working.
Apply the
AndroidStyle.xml
style template to your code in Android Studio.Run the unit tests with
gradlew connectedObaGoogleDebugAndroidTest
to make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)