Port Google Analytics fixes to the develop branch (develop) #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cagryInside
commented
Mar 4, 2015
cagryInside
commented
- Added map icon click event as discussed Report StopInfo event (develop) #234 (comment)
- Fix Including custom URLs when reporting events with GA. #237 - custom url reporting disabled
- Fix Add Google Analytics individually for trip/stop problem reports #244 - specific trip/stop problem reports
- Fix Change location accuracy threshold for Google Analytics #232 - location accuracy for analytics
- Agreed to keep OBA Android consistent with OBA Iphone as discussed in Including custom URLs when reporting events with GA. #237 (comment). So, the following differences added:
- Turned on Experimental Regions
- Turned off Experimental Regions
- Set region manually
barbeau
changed the title
| ObaAnalytics.reportEventWithCategory(ObaAnalytics.ObaEventCategory.UI_ACTION.toString(), | ||
| getString(R.string.analytics_action_button_press), | ||
| getString(R.string.analytics_label_button_press_experimental) + experimentalServers); | ||
| if (experimentalServers) |
|
@cagryInside are you still rebasing this? Two commits ended up in this PR. |
|
@barbeau I finish rebasing. I would like to merge two different commits if it is possible. One for custom url reporting , another for location accuracy issue. I thought, it would be better to have these issues in two different commits, since they are not related to each other. |
…disabled for develop branch
barbeau
added a commit
that referenced
this pull request
Mar 6, 2015
Fix #234 report stop info, Fix # 237 custom url reporting disabled - develop branch
|
Thanks @cagryInside! |
barbeau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.