Fix #946 - Don't show multiple notifications for reminders #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allows various application components to explicitly specify whether or not the TripService should run in the foreground * Never run in the foreground for ACTION_NOTIFY to avoid the "sticky" notification that shows while the service is running * Always run in the foreground on device reboot * Run in foreground for most other situations, even as a result of UI interactions. We could potentially scale this back if it's not found to be necessary. * Remove deprecated onStart() method, which dates back to Android 2.0 (TBT) * Some code cleanup * Update What's New text to remove reference to "sticky" notifications
|
@barbeau: Thank you for the review request. |
|
Thanks @paulnabanita1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #946.
@paulnabanita1 Could you please review and test? New expected behavior is that we shouldn't see the foreground service notification when the reminder notifications trigger.