Fix #215 - Add occupancy #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Define layout for occupancy * Add vector icon * Switch LinearLayout to ConstraintLayout in arrival list
* Convert inner LinearLayout to ConstraintLayout * Also do cleanup on arrival list item for hard-coded strings for debugging, extra imports, whitespace TODO: * Change visibility based on programmtic values * Consume API * Add content description for TalkBack
TODO: * Test margins and alignments against master branch
# Conflicts: # onebusaway-android/build.gradle
* Caveat - "the actual position of the view stays at the original position (before translation), it will be translated only visually. Thereby, onClick events will be only triggered from within the old position. See https://stackoverflow.com/a/51652722/937715." This is ok for us because the entire layout is one giant hit target based on what the Google Maps API supports for marker balloons, so we can't even detect the hit target for the chevron itself.
* For arrivals-and-departures-for-stop, trip-details, and trips-for-route APIs
Also reformat XML and add tools text
Directing inflating views doesn't seem to work in unit tests with getContext() or getTargetContext() so we'll use the adapter here instead to do it for us
We need a solid occupancy background color on the trip status header that has a green background
* For arrivals list, trip status, and vehicle marker balloon
* Also set occupancy transparency for past stops on trip details list
* By making view INVISIBLE instead of GONE the left and center occupancy silhouettes will remain in their place. When the views were GONE the left and center icons will change position to be equally between the left and right side.
* This should be replaced with icons after the design is finalized
* From change to make occupancy silhouettes views stay left justified when not full (367757c) * Also add description to unit test that doesn't require occupancy in response.
|
Final result looks like this for historical occupancy (for arrivals list - same icons used in vehicle marker balloon and trip details list):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design document:
https://docs.google.com/document/d/1TzP8_cEY8DaaVc_pBUtDbhxMGVuJlZeYWjHJXxzJ_-0/edit?ts=5c1dc928#
TODO: