-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aditya-Added-UnitTest-DeleteModal #2730
Conversation
… store and API requests
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @adityasure9 , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR 2730
@adityasure9
Tested the code changes and all test passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! I noticed that the recent changes primarily focus on adding/editing comments, but they don't seem to affect the actual functionality of the code. Could you please review the implementation and ensure that any required functional changes are also addressed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#2730
@adityasure9
Verified the unit test file, and all test cases successfully passed.
Thank you all, merging! |
Description
This PR introduces unit tests for the
DeleteModal
component to ensure its functionality works as expected. The test suite covers various scenarios, including generating the modal, dispatching actions upon deletion, and handling modal unmounting after user interactions.Main changes:
deleteTimeEntry
andupdateUserProfile
actions are dispatched when the "Delete" button is clicked.How to test:
npm install
to install dependencies.npm test DeleteModal.test.js
to run the tests locally.Screenshots or videos of changes: