Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aditya-Added-UnitTest-DeleteModal #2730

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

adityasure9
Copy link
Contributor

Description

This PR introduces unit tests for the DeleteModal component to ensure its functionality works as expected. The test suite covers various scenarios, including generating the modal, dispatching actions upon deletion, and handling modal unmounting after user interactions.

Main changes:

  • Added unit tests to validate the correct rendering of the DeleteModal component.
  • Tested the modal generation upon clicking the delete icon.
  • Verified that the modal unmounts correctly after clicking the "Cancel" button.
  • Checked that the deleteTimeEntry and updateUserProfile actions are dispatched when the "Delete" button is clicked.
  • Ensured that the modal unmounts after clicking anywhere outside the modal.

How to test:

  1. Check out the current branch.
  2. Run npm install to install dependencies.
  3. Use npm test DeleteModal.test.js to run the tests locally.
  4. Ensure that all test cases pass successfully.

Screenshots or videos of changes:

image

Copy link

netlify bot commented Sep 28, 2024

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit af7b2e8
🔍 Latest deploy log https://app.netlify.com/sites/highestgoodnetwork-dev/deploys/66f74ac65d4cc1000945cea7
😎 Deploy Preview https://deploy-preview-2730--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@ziyanw52 ziyanw52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I test this, and all the test cases passed.
501727484888_ pic_hd

Copy link

@nikhilpittala16 nikhilpittala16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR and all the test cases have passed.
Screenshot (212)

@geetamatkar
Copy link

Hi @adityasure9 ,
Tested this PR and all the test cases have passed.

pr2730

Copy link
Contributor

@jinxyou jinxyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
All test cases have passed. Great work!

Copy link

@Dk-21 Dk-21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR 2730
@adityasure9
Tested the code changes and all test passed.
PR 2730

Copy link

@ishangoel17 ishangoel17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All test cases are passing. Below is the screenshot for reference:
Capture2730

Copy link
Contributor

@aaryaneil aaryaneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I noticed that the recent changes primarily focus on adding/editing comments, but they don't seem to affect the actual functionality of the code. Could you please review the implementation and ensure that any required functional changes are also addressed?

@mianmiantea2019
Copy link
Member

All test cases are passing

image

Copy link

@slidracoon72 slidracoon72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2730
@adityasure9 
Verified the unit test file, and all test cases successfully passed.

2730

@tharunaa-1
Copy link

All the test cases passed as expected!

image

@beblicarl beblicarl self-requested a review October 4, 2024 10:45
@beblicarl
Copy link
Contributor

All tests passed successfully

image

@pallavithorat
Copy link

I have tested the PR and all the test cases have passed.
PR#2730

@one-community
Copy link
Member

Thank you all, merging!

@one-community one-community merged commit a4a1383 into development Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.