Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(win): option to keep qwerty shortcuts #150

Merged
merged 4 commits into from
Mar 2, 2024
Merged

feat(win): option to keep qwerty shortcuts #150

merged 4 commits into from
Mar 2, 2024

Conversation

Geobert
Copy link
Collaborator

@Geobert Geobert commented Mar 2, 2024 •
edited
Loading

This covers the windows part to keep qwerty shortcuts (AHK, KLC, C)

@Geobert Geobert mentioned this pull request Mar 2, 2024
Open
5 tasks
fabi1cazenave
fabi1cazenave requested changes Mar 2, 2024
View reviewed changes
Copy link
Collaborator

@fabi1cazenave fabi1cazenave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean code and smart implementation. Nice !

My only concern at the moment is that kalamine should raise a warning when generating keylayout or xkb_* files that this feature is not supported.

kalamine/cli.py Outdated Show resolved Hide resolved
@fabi1cazenave fabi1cazenave merged commit c9af422 into OneDeadKey:main Mar 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabi1cazenave fabi1cazenave fabi1cazenave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Geobert @fabi1cazenave