Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup/Remove cli cmd and data migration script for agency address f… #1065

Merged

Conversation

Tschuppi81
Copy link
Contributor

@Tschuppi81 Tschuppi81 commented Nov 7, 2023

People: Cleanup/Remove cli cmd and data migration script for agency address parsed from portrait field

TYPE: Feature
LINK: ogc-1053

@Tschuppi81
Copy link
Contributor Author

@Daverball is there an easy way to verify if a migration script has been invoked on an instance similar to upgrade tasks in upgrades table? I want to make sure they got executed before removing them...

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.18%. Comparing base (e0db0be) to head (63d13f7).
Report is 9 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
src/onegov/people/cli.py 87.14% <ø> (+17.59%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0db0be...63d13f7. Read the comment docs.

@Daverball
Copy link
Member

@Daverball is there an easy way to verify if a migration script has been invoked on an instance similar to upgrade tasks in upgrades table? I want to make sure they got executed before removing them...

Not unless you explicitly stored something into the database within the migration script that would let you determine that.

Copy link

linear bot commented Aug 9, 2024

@Tschuppi81 Tschuppi81 merged commit e5c3c3f into master Aug 16, 2024
14 checks passed
@Tschuppi81 Tschuppi81 deleted the feature/ogc-966-staka-cleanup-cli-cmd-and-data-migration branch August 16, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants