-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ogc 1493 react mode #1229
Open
BreathingFlesh
wants to merge
12
commits into
master
Choose a base branch
from
ogc-1493-react-mode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ogc 1493 react mode #1229
Commits on Mar 11, 2024
-
Add minified versions of react and use these
The minified .js are for production
Configuration menu - View commit details
-
Copy full SHA for 00f2569 - Browse repository at this point
Copy the full SHA 00f2569View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23589b6 - Browse repository at this point
Copy the full SHA 23589b6View commit details
Commits on Mar 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bc6089a - Browse repository at this point
Copy the full SHA bc6089aView commit details
Commits on Mar 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c5ff96d - Browse repository at this point
Copy the full SHA c5ff96dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a08d476 - Browse repository at this point
Copy the full SHA a08d476View commit details
Commits on Mar 26, 2024
-
Use create-react-class to wrap legacy React.createClass API.
create-react-class is a wrapper for the legacy React.createClass API. Using create-react-class, we can continue to use the deprecated way of creating React components - otherwise, we have to upgrade each component manually, a time and error-prone process. For now, we can use latest React without changing our components. However, we should update a component whenever we work on it to the latest format.
Configuration menu - View commit details
-
Copy full SHA for 803ed84 - Browse repository at this point
Copy the full SHA 803ed84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32d383c - Browse repository at this point
Copy the full SHA 32d383cView commit details -
Include react-transition-group
react-transition-group was moved away from React into a community-maintained project.
Configuration menu - View commit details
-
Copy full SHA for 8794892 - Browse repository at this point
Copy the full SHA 8794892View commit details -
Fixes Foundation prompts that are rendered with react.
Calling foundation() on a React-rendered element caused all handlers to quit working (i.e., onChange did never receive a callback). Wrapping the reveal element in a dedicated element and keeping the react-rendered part separate seems to work.
Configuration menu - View commit details
-
Copy full SHA for 9750701 - Browse repository at this point
Copy the full SHA 9750701View commit details
Commits on Apr 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 57cb87b - Browse repository at this point
Copy the full SHA 57cb87bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19f86ba - Browse repository at this point
Copy the full SHA 19f86baView commit details
Commits on May 27, 2024
-
Conflicts: src/onegov/swissvotes/assets/js/react-dom.min.js tests/onegov/form/assets/react-dom.min.js tests/onegov/form/conftest.py
Configuration menu - View commit details
-
Copy full SHA for 36fc765 - Browse repository at this point
Copy the full SHA 36fc765View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.