Feature/ogc 508 replace elastic search by postgres v2 #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 737fb14.
Tschuppi81
commented
Jul 19, 2024
| @@ -67,6 +71,9 @@ def reference(self, request: 'OrgRequest') -> str: | |||
| def reference_group(self, request: 'OrgRequest') -> str: | |||
| return request.translate(self.group) | |||
|
|
|||
| # FIXME: extra localized text is used for suggestions in the search but | |||
| # does not work with the ranking of the search results | |||
| # @hybrid_property | |||
| @cached_property | |||
| def extra_localized_text(self) -> str: | |||
There was a problem hiding this comment.
extra_localized_text is used for search suggestions but do not work when applying the ranking for search results. I changed to hybrid_property which throws
File "/home/reto/workspace/onegov-cloud/src/onegov/org/models/ticket.py", line 93, in extra_localized_text
q = object_session(self).query(Message)
^^^^^^^^^^^^^^^^^^^^
File "/home/reto/workspace/onegov-cloud/venv/lib/python3.11/site-packages/sqlalchemy/orm/session.py", line 3464, in object_session
util.raise_(
File "/home/reto/workspace/onegov-cloud/venv/lib/python3.11/site-packages/sqlalchemy/util/compat.py", line 182, in raise_
raise exception
sqlalchemy.orm.exc.UnmappedInstanceError: Class 'sqlalchemy.ext.declarative.api.DeclarativeMeta' is not mapped; was a class (onegov.org.models.ticket.FormSubmissionTicket) supplied where an instance was required?
How can I transform it to a hybrid property?
Tschuppi81
commented
Jul 19, 2024
| ) | ||
| # FIXME: sorting by rank_expression does not work | ||
| # with OrgTicketMixin::extra_localized_text | ||
| # query = query.order_by(rank_expression.desc()) |
There was a problem hiding this comment.
This is the counter part of the issue described in the above comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.
Commit message
:
TYPE: <Feature|Bugfix>
LINK:
HINT:
Checklist